use pathlib.Path#21
Conversation
|
Wow, thanks, that's a very thorough PR, updating the changelog and all 😍 That certainly makes my life easier 🙂 . I will have a look at the code. If you have time, could you do the following?
|
|
For the README.rst:
Additional changes are expected as well in tests (also getting rid of py.path there) |
|
Updated. Also fixed an existing error in the examples. |
omarkohl
left a comment
omarkohl
left a comment
There was a problem hiding this comment.
Thank you for the great work! Some comments inline and one more generic one:
- What is the purpose of src/pytest_datafiles/init.py ?
| @echo "test-all Run tests on every Python version with tox" | ||
| @echo "coverage Check code coverage quickly with Python 3" | ||
| @echo "dist Package" | ||
| @echo "README.rst Generate README.rst from docs/readme" |
There was a problem hiding this comment.
Please add the new make targets you created to the help text.
| @@ -0,0 +1,20 @@ | |||
| """Example: Reference files anywhere """ | |||
There was a problem hiding this comment.
I think all the examples should be in a top-level directory examples/ rather than tests/examples/ so they are easier to find. But I can also do that once this PR is merged, it's easy enough. As you prefer.
There was a problem hiding this comment.
I would also put the explanation of the example that is in the README as a docstring inside each example.py file. This way all the relevant info is in one place. Again, I can do this after merging the PR as you prefer.
There was a problem hiding this comment.
moved, added text to the docstring. Also included just short fragments in the README itself to focus on the highlights.
|
Leaving the |
2 participants
fixes #7